Customizable Switch Warning

ReSt · Post by **ReSt** » Fri Jan 27, 2012 2:24 pm

Switch warning does not yet work (version 677).
Cursor can not be moved right/left to select other switches than the 'T' switch

Reinhard

Post by **erazz** » Fri Jan 27, 2012 4:03 pm

You might be in "edit" mode. Try pressing <MENU> and trying again.

I'll take a look at it later to see if I can fix this.

ReSt · Post by **ReSt** » Fri Jan 27, 2012 4:06 pm

Menu button only allows to set/reset the 'T'-switch.
No chance to select another one of the switches.

Reinhard

Post by **MikeB** » Fri Jan 27, 2012 5:57 pm

Very odd, anyone else with this problem? It's working OK for me, and I've ported the code to ersky9x and it is working on that as well.

Mike.

Post by **cre8tiveleo** » Fri Jan 27, 2012 6:22 pm

Same issue here with two radios. One with sp board and one without

---
I am here: http://maps.google.com/maps?ll=44.056212,-79.476230

wheelspinner20 · Post by **wheelspinner20** » Fri Jan 27, 2012 6:27 pm

Yes, I just grabbed and loaded 677 last night.... Noticed the new line, wasnt sure what it was,,,, so I left it alone, with the knob scrolling enabled, I can get the cursor over to the R and it blinks, but cant get anything to change or select.

SP board on board.

Post by **cre8tiveleo** » Fri Jan 27, 2012 6:33 pm

With pot scroll on, can only go between T and R. 0 is highlite.

Also when the system boots with splash, back light is off, until splash is gone, then the backlight is on.

If you assign a switch for backlight, then you can have the bl on with splash boot, but , then you get a switch error if you use any switch other than throttle or rudder...

---
I am here: http://maps.google.com/maps?ll=44.056229,-79.476275

Spoogy · Post by **Spoogy** » Fri Jan 27, 2012 6:35 pm

r677 here also. Working fine!

Altough I don't know what that option does,

but I can select any of those letters TRE or number and highlight any of those with a menu button.

Spoogy · Post by **Spoogy** » Fri Jan 27, 2012 6:38 pm

cr8tive_leo wrote:With pot scroll on, can only go between T and R. 0 is highlite.

Also when the system boots with splash, back light is off, until splash is gone, then the backlight is on.

If you assign a switch for backlight, then you can have the bl on with splash boot, but , then you get a switch error if you use any switch other than throttle or rudder...

---
I am here: http://maps.google.com/maps?ll=44.056229,-79.476275

Same behavior in here with the backlight and potscroll, but with left/right buttons all switch warnings can be selected and highlighted.

Post by **cre8tiveleo** » Fri Jan 27, 2012 6:49 pm

left right doesn't work here at all.

Post by **erazz** » Fri Jan 27, 2012 6:58 pm

Weird.... Looking into it.

Maybe I just need to explain it? (Seems to me people actually got it...)

Post by **cre8tiveleo** » Fri Jan 27, 2012 7:02 pm

It makes sense to use.. you select the switch you want (or the ones you can in my case) then hit menu to select/de select that switch. I can only choose t and r. ID0 is already set off ... I can switch them in eepe (beta version too) and it works, you just can't within the radio. pot scroll only lets me go between t and r... left/right doesn't even over the cursor from t at all.

Hope that helps.

Spoogy · Post by **Spoogy** » Fri Jan 27, 2012 7:14 pm

All the same things here as above only that exception that with left/right (+ and -) buttons everything works and menu button select/de-select selected switch.

Post by **MikeB** » Fri Jan 27, 2012 8:43 pm

Well I'm confused with this, I can't see why it works for some, I don't think it should work at all

. I've been looking at it for the last hour or so. Oh well, keep trying.

Mike.

OK, got it. Erazz, you have some code:

Code: Select all

    case EVT_KEY_REPT(KEY_RIGHT):
    case EVT_KEY_FIRST(KEY_RIGHT):
        if(sub==1 && subSub<sizeof(g_model.name)-1 && s_editMode) mstate2.m_posHorz++;
        if(sub==19 && subSub<7) mstate2.m_posHorz++;

The 19 in the last line is not constant, it depends what speaker mode you have selected, 19 is correct if you use the stock beeper. This appears in two places KEY_RIGHT and KEY_LEFT.

Post by **erazz** » Fri Jan 27, 2012 9:24 pm

Ugh, never liked that bit.

That could be it.
Need to figure out a way to make it automatic.

Post by **MikeB** » Fri Jan 27, 2012 9:29 pm

after
#define DEFAULT_COUNT_ITEMS 24
add
int8_t sw_offset = -5 ;

after
if((g_eeGeneral.speakerMode == 1 || g_eeGeneral.speakerMode == 2) && g_eeGeneral.frskyinternalalarm == 1){ // add in alert red/org/yel
vCountItems = vCountItems + 3;
add
sw_offset -= 3 ;

then after
// SIMPLE_MENU("RADIO SETUP", menuTabDiag, e_Setup, COUNT_ITEMS+1);
SIMPLE_MENU("RADIO SETUP", menuTabDiag, e_Setup, vCountItems+1);
add
sw_offset += vCountItems ;

and then use sw_offset instead of the 19

Or something similar, its different depending whether or not FRSKY is compiled in. Either that, or move the switch warning above the speaker option, then it will always be at the same offset, probably easier to do, just changes the menu.

If I committed this, I'd commit some other changes I'm still testing.

Mike.

Post by **cre8tiveleo** » Fri Jan 27, 2012 9:39 pm

I changed to 'beeper' speaker from the piz thing, and, lo and behold, the left right works. *just confirming what mike said*

Still id0 can't be set or unset... at least on the radio, it's always highlighted.

Post by **erazz** » Fri Jan 27, 2012 9:49 pm

OK,

I committed it. I'll compile and post later tonight.

Post by **MikeB** » Fri Jan 27, 2012 9:55 pm

Did some more testing, now I've fixed the FRSKY version as well:

Code: Select all

#ifdef FRSKY
    int8_t sw_offset = -6 ;
    uint8_t vCountItems = DEFAULT_COUNT_ITEMS; //21 is default
		switch (g_eeGeneral.speakerMode){
				//beeper
				case 0:
                                                sw_offset += 1 ;
						break;
				//piezo speaker
			 	case 1:
                                                vCountItems = DEFAULT_COUNT_ITEMS + 3;
			 			break;
			 	//pcmwav
			  case 2:
                                                vCountItems = DEFAULT_COUNT_ITEMS + 2;
						break;	  	
		}		
		if((g_eeGeneral.speakerMode == 1 || g_eeGeneral.speakerMode == 2) && g_eeGeneral.frskyinternalalarm == 1){ // add in alert red/org/yel
				vCountItems = vCountItems + 3;
				sw_offset -= 3 ;
		}		
		
#else 
    int8_t sw_offset = -5 ;
                uint8_t vCountItems = DEFAULT_COUNT_ITEMS; //21 is default
		switch (g_eeGeneral.speakerMode){
				//beeper
				case 0:
						break;
				//piezo speaker
			 	case 1:
                                                vCountItems = DEFAULT_COUNT_ITEMS + 2;
			 			break;
			 	//pcmwav
			  case 2:
                                                vCountItems = DEFAULT_COUNT_ITEMS + 1;
						break;	  	
		}
#endif
    sw_offset += vCountItems ;

The pot scroll still doesn't work, I sort of know why, there is no MAXCOL for this row so it gets clobbered.

cr8tive_leo:
Re:ID0, that''s a feature, you can only have one of ID0, ID1 and ID2 on, but you MUST have one of them. If you set ID1, ID0 will go off automatically.

Mike.

ReSt · Post by **ReSt** » Fri Jan 27, 2012 10:28 pm

One basic question regarding the Switch warning:
When I set a switch in the menue (and switch warning activated), must the switch be on or off when I switch on the radio?

I just found it out:

All switches are checked and must be in the position according to the setup in the menue
You have to set the default switch positions, that is the position where the radio should power on without an error.
If you set a switch in the menue, it must be on (=1 in the diagnostic screen) and if you do not set a switch in the menue, it must be off (in the diagnostic screen) on power on.

Reinhard

Post by **cre8tiveleo** » Fri Jan 27, 2012 10:42 pm

MikeB wrote: cr8tive_leo:
Re:ID0, that''s a feature, you can only have one of ID0, ID1 and ID2 on, but you MUST have one of them. If you set ID1, ID0 will go off automatically.

Mike.

Figured as much, makes sense. get.. makes sense... nahh... I won't quit my day job.

agusta600gt · Post by **agusta600gt** » Fri Jan 27, 2012 11:23 pm

I was able to select any of the switches in the menu BEFORE calibrating...after calibrating,none selectable only 0 activated

Post by **MikeB** » Fri Jan 27, 2012 11:56 pm

Did you change the speaker mode as well as calibrating? Fixes for this problem are on their way.
Mike.

agusta600gt · Post by **agusta600gt** » Sat Jan 28, 2012 12:00 am

yes i did...is it related?

Post by **cre8tiveleo** » Sat Jan 28, 2012 12:15 am

Yes... Qui... Ja... Si

---
I am here: http://maps.google.com/maps?ll=44.056194,-79.476183

agusta600gt · Post by **agusta600gt** » Sat Jan 28, 2012 12:16 am

Post by **cre8tiveleo** » Sat Jan 28, 2012 2:42 am

686 works now with left/right. Pot scroll still stops at R.

Also.. is there anyway to have the splash screen light up on boot up? Right now you have to assign a switch and have it 'on' for the backlight. Prior to the switch menu, you didn't have to do this. Why did it change? It was good the way it was..

System boots.. no bl, until splash screen disappears. can't wow the Futaba guys that way...

agusta600gt · Post by **agusta600gt** » Sat Jan 28, 2012 8:50 am

+1

Automatic light at startup for a least5 seconds would be good then after that its up to our settings

ReSt · Post by **ReSt** » Sat Jan 28, 2012 10:21 am

Thanks Eraz, it's working now (on my radio

)

But there is the next idea:
Would it be possible to display, with the Switch alarm message, the names (shortcut) of those switches that trigger the alarm?

Because if you do not remember your correct default switch settings, it's a hard way to find your way thru all switch combinations.
At least there should be a possibility to bypass the warning (e.g. long press EXIT) to get access to the menue so you can check your defaults.

Reinhard

Spoogy · Post by **Spoogy** » Sat Jan 28, 2012 10:27 am

Yeah, I liked also to have backlight lid while system is booting (flash screen is on the screen). After that it could be controlled how it has been set.

openrcforums